Allow importing Cryptol foreign functions
#1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to access cryptol implementations of foreign functions
RyanGlScott
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Thanks, @qsctr! Aside from the comments below, it would be worth mentioning this in the CHANGES.md file and the SAW manual (under doc/manual), as this is a user-facing feature.
RyanGlScott
approved these changes
Aug 29, 2023
qsctr
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there exists a Cryptol implementation of the
foreignfunction, then we import it into SAWCore as a Cryptol expression, in the same way that we do for normal Cryptol bindings. If not, then we introduce it as an opaque constant with no definition, the same way we deal with unknown primitives.This requires an update of the
cryptolsubmodule so that we have support for Cryptol implementations offoreignfunctions.